Skip to content

Fix mypy check #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 13, 2020
Merged

Fix mypy check #156

merged 17 commits into from
Apr 13, 2020

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Apr 9, 2020 •
edited
Loading

  • style
    • fix all the mypy warning
    • config: move .flake8 to setup.cfg and add mypy, pytest config
  • ci
    • add mypy check
    • add stricter config but comment out those we not yet follow
    • remove redundant arugment (it's been configed in setup.cfg)
  • test(cz/customize): add test case initialize_cz_customize_failed

@Lee-W Lee-W marked this pull request as draft April 9, 2020 09:45
@codecov
Copy link

codecov bot commented Apr 9, 2020 •
edited
Loading

Codecov Report

Merging #156 into master will increase coverage by 0.03%.
The diff coverage is 93.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   91.54%   91.58%   +0.03%     
==========================================
  Files          33       33              
  Lines         769      784      +15     
==========================================
+ Hits          704      718      +14     
- Misses         65       66       +1
Flag Coverage Δ
#unittests 91.58% <93.10%> (+0.03%) ⬆️
Impacted Files Coverage Δ
commitizen/config/__init__.py 82.60% <50.00%> (ø)
commitizen/cz/customize/customize.py 84.78% <78.57%> (-0.22%) ⬇️
commitizen/commands/check.py 100.00% <100.00%> (ø)
commitizen/config/base_config.py 91.30% <100.00%> (ø)
commitizen/config/ini_config.py 84.61% <100.00%> (+0.83%) ⬆️
commitizen/config/toml_config.py 93.10% <100.00%> (+0.51%) ⬆️
commitizen/cz/__init__.py 100.00% <100.00%> (ø)
commitizen/cz/base.py 100.00% <100.00%> (ø)
...en/cz/conventional_commits/conventional_commits.py 100.00% <100.00%> (ø)
commitizen/cz/jira/jira.py 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d4e3b9...906d1fb. Read the comment docs.

@Lee-W Lee-W marked this pull request as ready for review April 9, 2020 10:40
@Lee-W
Copy link
Member Author

Lee-W commented Apr 9, 2020

@woile I made some change on config files (i.e. setup.cfg) of this project. Could you check whether they make sense to you? Other than that is just fixing mypy warnings.

@Lee-W Lee-W changed the title WIP: Fix mypy check Fix mypy check Apr 10, 2020
woile
woile reviewed Apr 10, 2020
View reviewed changes
@woile
Copy link
Member

woile commented Apr 10, 2020

Thanks for taking the time to do this!

Lee-W added 17 commits April 10, 2020 22:11
@Lee-W
style(mypy): unify config path input as Union[str, Path] and output a…
25e8f7e 
…s Path
@Lee-W
refactor(config): fix mypy warning for _conf
e0a2ff0
@Lee-W
refactor(cz): add type annotation for each function in cz
ded92b2
@Lee-W
refactor(cz/base): fix config type used in base cz
a6dde29
@Lee-W
refactor(config/base): use Dict to replace dict in base_config
5fad7b7
@Lee-W
refactor(commands/check): fix type annotation
cdfe112
@Lee-W
fix(cz/customize): add error handling when customize detail is not set
c4b1591
@Lee-W
style: reformat
28949ea
@Lee-W
refactor(cz): add type annotation to registry
9c12b9f
@Lee-W
style(config): move .flake8 to setup.cfg and add mypy, pytest config
db8e37e
@Lee-W
ci(scripts/test): remove redundant arugment (it's been configed in se…
2754a34 
…tup.cfg)
@Lee-W
ci(scripts/test): add mypy check
c599295
@Lee-W
style: remove unused import
65edcc3
@Lee-W
refactor(mypy): fix mypy check by checking version.pre exists
2738b74
@Lee-W
refactor(cz/customize): remove unused mypy ignore
4955257
@Lee-W
ci(mypy-config): add stricter config but comment out those we not yet…
582f2a2 
… follow
@Lee-W
test(cz/customize): add test case initialize_cz_customize_failed
906d1fb
@Lee-W
Copy link
Member Author

Lee-W commented Apr 13, 2020 •
edited
Loading

@woile If other configurations look good to you, I'll merge this pull request late today 🙂

@woile
Copy link
Member

woile commented Apr 13, 2020

Yes it's fine 👍 if any of the new settings starts annoying we can discuss about changing it.

@Lee-W Lee-W merged commit a762c9e into master Apr 13, 2020
@Lee-W Lee-W deleted the fix-mypy-check branch April 20, 2020 04:05
@Lee-W Lee-W mentioned this pull request Apr 24, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woile woile woile left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lee-W @woile